UI polish, CSS import fidelity, and editable group layers - #21
Merged
Conversation
Add scaleX/scaleY support, normalize line/path placement for keyframe merge, correct ellipse pivot math for wheel spin, and show progress while importing HTML animations. Co-authored-by: Cursor <cursoragent@cursor.com>
Paint loading toasts before heavy import work, add a visible progress bar, and resolve strict build failures in css-keyframes and the train import regression test. Co-authored-by: Cursor <cursoragent@cursor.com>
* Improve CSS animation import timing fidelity for train HTML. Parse animation-delay, easing, steps(), and alternate direction from class rules and inline styles so streaks stagger, jitter snaps, and bob uses ease-in-out. Co-authored-by: Cursor <cursoragent@cursor.com> * Fix train bob origin scope and wheel spoke rotation pivot. Include nested jitter shapes when resolving parent train transform origins, and rotate imported path layers around their visual center so wheel cross lines stay attached. Co-authored-by: Cursor <cursoragent@cursor.com> * Fix uniform wagon jitter across nested CSS group transforms. Apply group bob/jitter as shared translation plus rotation tilt, scope train transform origins through nested animated groups, and keep wheel spin on the rotation property only so path cars match the middle rect. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
…up layers. Store CSS group animations on layerGroups instead of baking into every child, compose them at playback, and align import tests with the new model. Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
Author
|
Branch synced: pushed |
…icts. Keep branch-side group layers, Lottie progress, and path pivot transforms over overlapping PR #19 changes on main. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
layerGroups(project v13) and compose them at playback instead of baking into every child layer.Test plan
npm test -- --run— 183 tests passingnpx tsc -b— clean typechecktrain-404-bg.htmland verify wagons jitter together, wheels spin, pantograph visibleMade with Cursor