Skip to content

Markus test#28

Open
mark141 wants to merge 180 commits into
masterfrom
markus_test
Open

Markus test#28
mark141 wants to merge 180 commits into
masterfrom
markus_test

Conversation

@mark141

@mark141 mark141 commented Dec 18, 2019

Copy link
Copy Markdown
Collaborator

Issue of testing on the github environment is finished. ;-)

@codecov-io

codecov-io commented Dec 18, 2019

Copy link
Copy Markdown

Codecov Report

Merging #28 into master will decrease coverage by 6.2%.
The diff coverage is 93.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage     100%   93.79%   -6.21%     
==========================================
  Files           2        6       +4     
  Lines          68      934     +866     
==========================================
+ Hits           68      876     +808     
- Misses          0       58      +58
Impacted Files Coverage Δ
mypackage/all_groove.py 0% <0%> (ø)
mypackage/transformations.py 100% <100%> (ø)
mypackage/_utility.py 100% <100%> (ø)
mypackage/geometry.py 100% <100%> (ø) ⬆️
mypackage/visualization.py 100% <100%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d11d804...ef7cbfd. Read the comment docs.

vhirtham and others added 27 commits February 6, 2020 16:19
* added U and V groove as functions
* input is a dictionary
* output is a profile
Now the input can be given with '**dict' .
Depending on input width, the edge will be calculated
…Added a rough structure for calling different groove types.
@pep8speaks

pep8speaks commented Feb 24, 2020

Copy link
Copy Markdown
Contributor

Hello @mark141! Thanks for updating this PR.

Line 22:1: E302 expected 2 blank lines, found 1
Line 37:52: W292 no newline at end of file

Comment last updated at 2020-02-24 14:19:46 UTC

* groove function calls a helper function.
* main function grooveType now calls the corresponding groove function
@vhirtham

Copy link
Copy Markdown
Owner

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- tests/test_groove.py  4
- mypackage/all_groove.py  4
         

Clones added
============
- mypackage/all_groove.py  4
         

See the complete overview on Codacy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants