fix(ARC-3598): fix reusability filter for audio / video objects#685
Merged
Conversation
reunefe
approved these changes
Jun 12, 2026
There was a problem hiding this comment.
Pull request overview
This PR addresses ARC-3598 by updating the Elasticsearch reusability filter so it can match both newspaper objects (via dcterms_rights_statement) and audio/video objects (via reuse_category), and updates the QueryBuilder unit tests accordingly. Several files also include import-only formatting changes.
Changes:
- Extend the reusability filter to query both
dcterms_rights_statementandreuse_categoryfor matching items across object types. - Update
QueryBuildertests to assert the new query shape/fields. - Apply import formatting changes in a few modules (no logic changes there).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/users/services/users.service.ts | Import formatting only. |
| src/modules/sitemap/services/sitemap.service.ts | Import formatting only. |
| src/modules/organisations/mocks/organisations.mocks.ts | Import formatting only. |
| src/modules/material-requests/services/material-requests.service.ts | Import formatting only. |
| src/modules/ie-objects/elasticsearch/queryBuilder.ts | Update reusability filter to include AV reuse category field; minor import formatting change. |
| src/modules/ie-objects/elasticsearch/queryBuilder.spec.ts | Update tests to reflect the expanded reusability filter behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://meemoo.atlassian.net/browse/ARC-3598