Skip to content

DEV-1846 Use organization label instead of tenant name#44

Open
jaameemoo wants to merge 3 commits into
masterfrom
dev-1846-use-cp-name
Open

DEV-1846 Use organization label instead of tenant name#44
jaameemoo wants to merge 3 commits into
masterfrom
dev-1846-use-cp-name

Conversation

@jaameemoo

Copy link
Copy Markdown

No description provided.

The tenant name is invariant and not human-readable (all lowercase and
no spaces).  The method name was renamed to better reflect its purpose
(i.e. retrieve the organization label, not its label in the MAM).
@jaameemoo jaameemoo requested a review from spacid July 1, 2024 11:57
@jaameemoo jaameemoo self-assigned this Jul 1, 2024
It is not the MAM label anymore, so change it to "ORG" instead of "MAM".

@spacid spacid left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ziet er goed uit!

Comment thread meemoo/services.py Outdated
@jaameemoo jaameemoo requested a review from spacid July 2, 2024 12:57
@spacid

spacid commented Jul 11, 2024

Copy link
Copy Markdown
Collaborator

We doen normaal geen functionele reviews in een PR maar gaat dit wel lukken? Is die mam_label niet nodig om de destination folder op de tra te bepalen, zowel FTP van XML als opstellen van transfer message? (@maartends @RudolfDG )

@maartends

Copy link
Copy Markdown
Member

Correct @spacid. @jaameemoo, → DEV-1846.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants