DEV-1631 Add collateral type to title#46
Open
AaronVr wants to merge 1 commit into
Open
Conversation
When creating the collateral sidecar for a collateral submission (i.e., a submission to the mam-collaterals bucket), add human readable info regarding collateral type to the title. This is to make it easier to distinguish collaterals based on title alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When looking up items based on pid, the current collateral results have titles that are not very meaningful (e.g., "Collateral: pid: <pid>"). It would be nice to display some human readable information about the collateral in the title to make them easier to understand.
We do this by checking each
collateral_typeagainst"openOt"and"closedOt". These are the only collateral types currently in use.A possible addition could be to append
object_usein case neither"openOt"nor"closedOt"are matched.