Open
Conversation
benjirewis
commented
Mar 13, 2026
| ctx, | ||
| conf.Cloud.AppAddress, | ||
| conf.Cloud.Secret, | ||
| conf.Cloud.GetCloudCredsDialOpt(), |
Author
There was a problem hiding this comment.
Change associated with rdk bump:
grpc.NewAppConn now takes an RPC dial option instead of an ID, but it can be constructed with conf.Cloud.GetCoudCredsDialOpt() (that's what we do in rdk).
| return nil, resource.ErrDoUnimplemented | ||
| } | ||
|
|
||
| func (cc *conditionalCamera) Image(ctx context.Context, mimeType string, extra map[string]interface{}) ([]byte, camera.ImageMetadata, error) { |
Author
There was a problem hiding this comment.
Change associated with rdk bump:
Image is no longer a part of the Camera interface, and camera.ImageMetadata is no longer a type. I kept the changes fairly minimal, but tried to account for this. There's more dead code lying around, but I wanted to do something quick.
| test.That(t, err.Error(), test.ShouldContainSubstring, "one of window_seconds, window_seconds_after, or window_seconds_before can be negative") | ||
| } | ||
|
|
||
| func TestImage(t *testing.T) { |
Author
There was a problem hiding this comment.
Removed tests that assert on/use Image (now gone).
| github.com/rhysd/actionlint v1.7.8 | ||
| go.viam.com/rdk v0.105.1-0.20251213204917-2ff3c7d9ab45 | ||
| go.opentelemetry.io/otel v1.38.0 | ||
| go.viam.com/rdk v0.116.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
rdkversion to have access tordk/module/tracepackage and minimally changes module code to suppor that. Adds spans to background worker code.Why
We want to gather better timing information about the
captureImageInBackgroundbackground worker.Testing
Haven't tested at all.