Conversation
Replace the mock Diff tab with a singleton Review panel that lists the working tree versus merge-base(HEAD, default) — PR-style three-dot review — and previews each file with Pierre. On the default branch the base is HEAD, so only uncommitted work is shown.
|
React Doctor found 4 issues in 4 files · 4 warnings · score 87 / 100 (Great) · full project 4 warnings
Reviewed by React Doctor for commit |
Review now switches among uncommitted, committed three-dot, and vs-branch (including remote-tracking refs), shows the full workspace tree with git badges, and stacks collapsible Pierre diffs that the tree can locate.
cursor
Bot
changed the title
Local branches like feature/oauth were landing in the Remote group because the toolbar split on `/`. git.branch now returns remotes separately so the select can keep origin/main remote without mislabeling slashed local names.
alignItemWithTrigger scrolled the vs-branch menu to origin/main and clipped the Remote group. Open below the trigger so Local and origin/main are both on screen without scrolling.
oxwen11
marked this pull request as ready for review
August 17, 2026 16:58
GitService is on the serve path, so tsdown inlines simple-git into the CLI. deps.onlyBundle fails closed; list simple-git and its tree so Code check can build @vibest/cli.
Mode and branch triggers now match the project picker: transparent, no shadow, hover accent. The header already uses a ghost refresh button.
Coss SelectTrigger hard-codes ChevronsUpDown. Render the same ghost Button chrome as the harness picker so compare mode and vs-branch use ChevronDown.
Resolve the server public-slice conflict by keeping main's removal of HarnessAgentDomainLayer (GitService stays on AgentRuntimeLayer). Point the review panel at content-panel/model after the core rename.
Keep this branch's git contract (status/review/diff plus remotes) so Review still works; composer only reads branch.current. Wire pty next to git, point the shell at features/terminal, and leave the mock Diff panel out — Review replaces it.
@effect/vitest layer({ timeout }) only covers hooks, so spawn tests still
hit vitest's 5s default while turbo runs build/test/typecheck together.
Raise the package testTimeout to 30s and poll for stop tombstones instead
of sleeping 100ms.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| }, | ||
| }); | ||
|
|
||
| function ReviewPanelView({ instance }: { instance: PanelHandle<ReviewPayload> }) { |
There was a problem hiding this comment.
React Doctor · react-doctor/no-high-complexity-react-function (warning)
ReviewPanelView has cyclomatic complexity 24, cognitive complexity 19, and maximum nesting depth 1, so its React logic is hard to understand and change. Extract independent branches into components or hooks.
Fix → Extract independent render branches and state logic into focused components or hooks until the control flow is easy to follow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the mock Diff tab with a singleton Review panel: full workspace tree, stacked collapsible diffs, and explicit compare modes.
Compare modes
HEAD, including untracked filesorigin/mainwhenorigin/HEADexists), ignoring the dirty worktreeorigin/main, …), including uncommitted work. Nogit fetch— uses refs already on diskUnknown
otherrefs returnREF_NOT_FOUND.git.branchlistsrefs/headsandrefs/remoteswithout strippingorigin/, and returnsremotesseparately so the vs-branch select can group Local vs Remote without treating slashed local names (feature/oauth) as remotes.Layout
CodeViewstacked diffs, file headers on, click a header to collapse/expandFileTreeof the whole workspace (fs.readTree) plus deleted review paths, with git-status badges. Click a changed file to scroll the stack to itfeatures/reviewcopies the Files tree adapter pattern and does not importfeatures/files.Surface
git.review/git.difftake{ cwd, mode?, other?, path? }{ mode?, other?, path? }. Collapse state is live-onlyVerify
turbo test typecheckfor@vibest/contract,@vibest/server,@vibest/app;pnpm lint:check;pnpm format:check; react-doctor 100.Acceptance walkthrough (demo repo on
feature/oauthwithorigin/mainalready on disk):review-panel-v2-acceptance.mp4
To show artifacts inline, enable in settings.