Repository navigation
Drop Thinking label after reasoning ends - #289
Merged
Merged
Conversation
Settled blocks said Thinking... because the trigger invented a duration of 0. Label them Thought, and stop hiding reasoning parts inside tool batches. Co-authored-by: Cursor <cursoragent@cursor.com>
|
React Doctor found 1 issue in 1 file · 1 warning · score 92 / 100 (Great) · full project Reviewed by React Doctor for commit |
pie #73 only changed packages/ui reasoning — wiring hidden reasoning parts was extra scope. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Port of pie #73. Finished reasoning stayed on Thinking... because the trigger treated a missing duration as still thinking, and invented elapsed time from
Date.now().Settled blocks now say Thought. Thinking... only while the part is streaming. Duration is shown only when a caller supplies a real value.
vibest previously dropped reasoning parts in the transcript, so the label fix would have been invisible. This rewrite also renders those blocks (empty settled ones stay hidden).
Test plan
turbo run test --filter=@vibest/app --force -- reasoning-partMade with Cursor