Conversation
Pin mise, packageManager, and the lockfile together so CI and Turbo run the same stable pnpm 12.4.1 binary. Co-authored-by: Cursor <cursoragent@cursor.com>
|
React Doctor found 1 issue in 1 file · 1 warning · score 91 / 100 (Great) · full project 1 warning
Reviewed by React Doctor for commit |
tsdown's deps.onlyBundle whitelist rejected simple-git (and its transitive deps) when compiling the CLI from @vibest/server's git service, which already breaks @vibest/cli#build on main. Co-authored-by: Cursor <cursoragent@cursor.com>
OutgoingMessage requires delivery; the late-outgoing ignore case was still constructing a sending entry without it, which breaks typecheck on main as well as this branch. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
Wrong target — this work belongs on oxwen11/pie, not vibest-dev/vibest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
12.0.0-rc.6to stable12.4.1(mise.toml/mise.lockandpackage.jsonpackageManager).packageManagerDependenciessection so--frozen-lockfilematches CI.@vibest/clitsdowndeps.onlyBundlegap forsimple-git(and transitive deps) so Code check can pass; same failure reproduces onmainunder12.0.0-rc.6.Replaces the fork PR #300 (cross-repo head skipped self-hosted Check / React Doctor).
Test plan
mainpnpm install --frozen-lockfilepnpm turbo run build --filter=@vibest/cli --force