This repository was archived by the owner on Oct 8, 2023. It is now read-only.
[feat] PEP8 Support#110
Open
Zheaoli wants to merge 8 commits into
Open
Conversation
cclauss
reviewed
Jul 3, 2018
| name: Code Style Check | ||
| command: | | ||
| . venv/bin/activate | ||
| flake8 vibora |
Contributor
There was a problem hiding this comment.
This misses the Python syntax error in #32 that flake8 is capable of finding.
Author
There was a problem hiding this comment.
@cclauss
I check this issue. The author has fixed this problem.
added 2 commits
July 3, 2018 23:25
Author
Contributor
|
Why flake8 vibora and not flake8 . to test the entire repo? Don’t we want to also automate the process of finding issues in our ./samples and ./tests? |
Author
|
@cclauss OK I will fix it |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add flake8 checking in CI
add flake8 config file to ignore some unnecessary option such as:E501 line too long ,F401 '.router.*' imported but unused
fix some code style problem