fix: allow profile menu to close on icon click#134
Open
singhrishiranjan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the ProfileMenu component where the dropdown menu would not close if the user clicked the profile icon while the menu was already open.
Motivation and Context
Previously, users expecting to toggle the menu off by clicking the user icon were unable to do so. Because the menu would rapidly close and reopen in the background, it appeared "stuck" in the open position. This update restores expected, standard toggle behavior and improves the overall user experience.
Technical Explanation
The bug was caused by a timing conflict between the document's mousedown event listener (used for detecting outside clicks) and the button's React onClick event.
What was happening:
The Solution:
How to Test