Open
Conversation
Added label for upper grid line Equally spaced all labels above its line Change format to add decimal digit when needed to avoid duplicate labels
8e84d66 to
48f03cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves Y-axis label rendering in all line charts. Labels now show meaningful, non-repeating values and include decimals only when the data range is too small to differentiate values without them. Also adds the maximum value label at the top of the chart.
closes #202
Changes
ChartDrawUtils.ktdrawYAxisLabels: now renders 5 labels (including upper grid line) instead of 4%.0fformat by default, switching automatically to%.1fwhen any two adjacent labels would otherwise display the same integer valueChargeDetailScreen.ktandDriveDetailScreen.kt—BatteryChartCard