Skip to content

fix: Safari playback stall with overrideNative and experimentalUseMMS #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Demenus wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

fix: Safari playback stall with overrideNative and experimentalUseMMS #1601

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/playlist-controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,13 @@ export class PlaylistController extends videojs.EventTarget {
label: 'segment-metadata'
}, false).track;

this.segmentMetadataTrack_.mode = 'hidden';
// Only disable segment metadata track in Safari/iOS when using overrideNative HLS
if ((videojs.browser.IS_ANY_SAFARI || videojs.browser.IS_IOS) &&
Copy link
Copy Markdown

@skrhlm skrhlm Apr 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the IS_IOS check here may be redundant, anything that falls under IS_IOS would also be matched by IS_ANY_SAFARI.

this.sourceType_ === 'hls') {
this.segmentMetadataTrack_.mode = 'disabled';
} else {
this.segmentMetadataTrack_.mode = 'hidden';
}

this.decrypter_ = new Decrypter();
this.sourceUpdater_ = new SourceUpdater(this.mediaSource);
Expand Down
Loading