Skip to content

security: strip Axios config/request objects from serialized error re… #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nareshkumawat-star wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −10
Open

security: strip Axios config/request objects from serialized error re… #653

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86dd545
security: strip Axios config/request objects from serialized error re…
Jun 4, 2026
17d9398
Merge branch 'main' into fix/error-handler-security
Nareshkumawat-star Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions server/middleware/errorHandler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
module.exports = (err, req, res, next) => {
console.error('❌ Error:', err.stack || err.message);
const status = err.status || 500;
const isDev = process.env.NODE_ENV === 'development';
const message = (status >= 400 && status < 500) || isDev
? (err.message || 'Internal server error')
: 'Internal server error';
module.exports = (err, req, res, next) => {

Check warning on line 1 in server/middleware/errorHandler.js

View workflow job for this annotation

GitHub Actions / Run ESLint 

'next' is defined but never used

Check failure on line 1 in server/middleware/errorHandler.js

View workflow job for this annotation

GitHub Actions / Run ESLint 

'module' is not defined
console.error('❌ Error:', err.message);

res.status(status).json({
error: message,
...(isDev && { stack: err.stack }),
// Strip sensitive request config and request objects from Axios/HTTP errors to prevent leaking keys/headers
if (err.config) {
delete err.config;
}
if (err.request) {
delete err.request;
}

res.status(err.status || 500).json({
error: err.message || 'Internal server error',
...(process.env.NODE_ENV === 'development' && { stack: err.stack }),

Check failure on line 14 in server/middleware/errorHandler.js

View workflow job for this annotation

GitHub Actions / Run ESLint 

'process' is not defined
});
};
Loading