should be ready#188
Open
lomparhernandez wants to merge 5 commits into
Open
Conversation
i've been actually doing this one ahead of time but never comitted. oops nice to know the utf-8 character scaping is still a thing these days
the instructions said refactor with sass as well
refactoring although there's no ruby in here or any nested css but I guess it's a good practice if VCS says so, these must be industry standards these days.
Author
|
I guess bootstrap is actually really fun for prototyping. Grid looks interesting as well to make use of the DRY principle, typing "display:block;width:100%;height:auto;" a hundred times everyday gets boring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
right?