RSpec Calculator Submission#77
Open
yxlau wants to merge 3 commits into
Open
Conversation
remis1889
reviewed
May 14, 2017
| it "properly divides numbers" do | ||
| expect(c.divide(8,2)).to eq(4) | ||
| expect(c.divide(-8,2)).to eq(-4) | ||
| expect(c.divide(-8.0,-2)).to eq(4.0) |
There was a problem hiding this comment.
It raises an ArgumentError when the second argument is < 0
| it "handles decimal powers" do | ||
| expect(c.pow(27,1/3.0)).to eq(3.0) | ||
| expect(c.pow(27,-1/3.0)).to be_within(0.05).of(0.3) | ||
| end |
There was a problem hiding this comment.
Also, check if it handles the case when power is 0
| expect{ c.sqrt(-4) }.to raise_error(ArgumentError) | ||
| end | ||
| it "returns 2-digit decimals for non-round roots" do | ||
| expect(c.sqrt(27)).to eq(5.20) |
There was a problem hiding this comment.
check if the output has 2 decimal places exactly.
|
|
||
| describe "#stringify" do | ||
| it "returns output in form of string when stringify is true" do | ||
| expect(c_s.output(c.add(1,2))).to be_kind_of(String) |
There was a problem hiding this comment.
check if it returns a string for all the main methods - add, subtract, multiply etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.