added solution #89
Open
NawarYossef wants to merge 2 commits into
Open
Conversation
remis1889
reviewed
May 14, 2017
remis1889
left a comment
remis1889
left a comment
There was a problem hiding this comment.
You should also test all operations when stringify = true
|
|
||
| it "divide a float and an integer" do | ||
| expect(calculator.divide(2.4, 2)).to be_within(0.5).of(1) | ||
| end |
There was a problem hiding this comment.
divide should raise an ArgumentError if second argument is less than equal to zero
| end | ||
|
|
||
| it "returns 2-digit decimals for non-round roots" do | ||
| expect(calculator.sqrt(5.2)).to eq(2.28) |
There was a problem hiding this comment.
check if the result has 2 decimal places exactly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.