Add Exec and Query methods to FakePDO#6
Conversation
src/FakePdo.php
Outdated
| } | ||
|
|
||
| $sth = $this->prepare($statement); | ||
| if ($sth->execute()){ |
There was a problem hiding this comment.
I believe this is the correct way to replicate the internal logic
src/FakePdo.php
Outdated
| { | ||
| $sth = $this->prepare($statement); | ||
| $sth->execute(); | ||
| return $sth; |
There was a problem hiding this comment.
Not certain if anything new is needed here to replicate internal logic but this does run properly
|
So the fail on the build is coming from the Whereas the tests run on PHP 8 which requires this to be typed as But if we do that it will break on anything <PHP8. I wonder if this requires the tests to be run on the min supported version (PHP 7.1 according to composer.json)? |
|
Thanks! Please merge/rebase master! I've introduced separate |
|
So the last Psalm build on actions failed due to a Docker error... to make it build again I pushed some new But on the plus side, all checks now pass with the split out PHP7/8 classes! I'll update the Codeception branch at Codeception/module-db#20 to use a specific class too. |
|
Thanks! |
Adds other public methods (rather than just
prepare()toFakePdo)The current
masterbranch state of Psalm surfaces the following fails:This branch does not resolve these, but also does not add new fails.