Using bigger instruction port to get more throughput on data register ATA read/write#557
Open
LukeHale59 wants to merge 1 commit intovinc:trunkfrom
Open
Using bigger instruction port to get more throughput on data register ATA read/write#557LukeHale59 wants to merge 1 commit intovinc:trunkfrom
LukeHale59 wants to merge 1 commit intovinc:trunkfrom
Conversation
Owner
|
Sorry about the delay in answering this PR, I've been wondering about it because it seems that on the ATA spec this register is 16 bit max. I'm using MOROS on real hardware with real HDDs so I can't merge it. I'll probably implement DMA transfers instead of PIO to speed things up instead of optimizing the current driver. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switched the data register in ata.rs to u32 instead of u16. Using a bigger instruction port on the data register gives you more throughput to disk. In my testing, it was about 15% faster for writes and 20% faster for reads. @vinc