[GPX] added support for fractional digit in timestamps#108
Open
sathoeni wants to merge 1 commit intovincentneo:masterfrom
Open
[GPX] added support for fractional digit in timestamps#108sathoeni wants to merge 1 commit intovincentneo:masterfrom
sathoeni wants to merge 1 commit intovincentneo:masterfrom
Conversation
Owner
|
Thanks for your pull request. Have you checked whether if the code changes have any major impact on file parsing performance, especially with GPX files containing thousands of track points? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GPX-Standard allows timestamps with fractional digits.
To export such files and benefit from higher GPX resolution, I've added the option to export a GPX File with timestamps having fractional digits.
It is an opt-in feature. The default export does not have fractional digits to ensure compatibility.
I've also switched to the ISO8601 Dateformatter for Apple Platforms.
https://developer.apple.com/documentation/foundation/iso8601dateformatter