fix(deps): bump the go toolchain to 1.26.6 for the stdlib advisories - #359
Merged
Conversation
govulncheck started failing on every PR: the go directive pinned 1.26.5 and each workflow resolves its toolchain from go.mod, so CI kept building against a standard library with seven reachable advisories - GO-2026-6218 (net/url), GO-2026-6091 (html/template), GO-2026-6090 (crypto/tls), GO-2026-6089 and GO-2026-5026 (net/http), GO-2026-6088 (encoding/xml) and GO-2026-5972 (encoding/asn1). All seven are fixed in 1.26.6 and none involve a third-party module. Bumps the go directive and the builder image in the Dockerfile to match. No dependency or source change: govulncheck reports no vulnerabilities against the new toolchain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
govulncheckfails on every PR against main.go.modpinnedgo 1.26.5and every workflow resolves its toolchain from that file (go-version-file: go.mod), so CI kept building against a standard library that now carries seven reachable advisories:net/urlinternal/infrastructure/backup/s3.go:252html/templateinternal/presenters/cli/server_cmd.go:68crypto/tlsinternal/infrastructure/mailer/mailer.go:166and 5 othersnet/httpinternal/presenters/cli/server_cmd.go:68encoding/xmlinternal/infrastructure/backup/s3.go:205encoding/asn1internal/application/clientcrypto/rsa.go:47net/httpinternal/presenters/cli/server_cmd.go:99All seven are standard library, all are fixed in go1.26.6, and no third-party module is implicated. Main was last green on 11 Aug (b3085e5); the advisories landed since, so this is failing on unrelated PRs such as #358.
Change
go.mod:go 1.26.5->go 1.26.6Dockerfile: builder imagegolang:1.26.5-alpine->golang:1.26.6-alpineNo dependency change, no source change,
go.sumuntouched.Verification
Built and scanned locally against the bumped toolchain:
Note for anyone building locally: your toolchain needs to be go1.26.6, which the default
GOTOOLCHAIN=autofetches on first build.