Conversation
vineetjc
reviewed
Dec 5, 2018
vineetjc
left a comment
vineetjc
left a comment
Owner
There was a problem hiding this comment.
I need your opinion on making a separate executable file that installs dependencies vs this.
| dependencies = ['pygame'] # to add furture dependencies | ||
| subprocess.call([sys.executable, '-m', 'pip', 'install'] + dependencies) | ||
| import pygame | ||
| main() |
Owner
There was a problem hiding this comment.
What is main()? Please check if this is a NameError not just for me.
Owner
|
About the background change: One of the 4 images that I've used, coinfallbg4.jpg (hole in the white wall) won't show the black 'Main Menu' text. It's your call on how to change this. |
Owner
|
@Vishwaak resolve conflicts please |
Author
|
Merge conflicts resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.