Fix thread safety: dispatch native AppKit/NSUserDefaults reads to main thread - #10
Open
karlvr wants to merge 1 commit into
Open
Fix thread safety: dispatch native AppKit/NSUserDefaults reads to main thread#10karlvr wants to merge 1 commit into
karlvr wants to merge 1 commit into
Conversation
…n thread nativeGetApplicationAppearanceName was reading NSApp.appearance directly from the JNI calling thread. nativeGetAppearanceSettings was reading NSUserDefaults and NSWorkspace accessibility properties off the main thread. Both now use runOnMainThread to safely access these APIs.
Contributor
|
Oddly enough, I experienced a beach ball today that might have been caused by this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple more native threading suggestions:
nativeGetApplicationAppearanceNamewas readingNSApp.appearancedirectly from the JNI calling thread.nativeGetAppearanceSettingswas readingNSUserDefaultsandNSWorkspaceaccessibility properties off the main thread. Both now userunOnMainThreadto safely access these APIs. Also we're gathering this information all at once, on the main thread, to prevent any races if things change and result in maybe inconsistencies.