Update the RPM URI to refer to GitHub, not RedHat.#114
Update the RPM URI to refer to GitHub, not RedHat.#114RokeJulianLockhart wants to merge 2 commits intovirtio-win:masterfrom
Conversation
Updates the RPM specification URI to refer to this GitHub repository, rather than RedHat. Signed-off-by: Mr. Beedell, Roke Julian Lockhart (RJLB) <wy46xghh@rokejulianlockhart.addy.io>
Summary of ChangesHello @RokeJulianLockhart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the URL in the virtio-win.spec file to point to the project's GitHub repository instead of a generic RedHat URL. This is a good improvement for clarity. I've also suggested adding a BugURL to point to the GitHub issues page, as you mentioned in the description, which would be a helpful addition for users.
|
Reporting bugs to virtio-win-pkg-scripts is only for the installer related issues (also not recommended). Driver bugs and actually any issues in general should be reported to https://github.com/virtio-win/kvm-guest-drivers-windows/issues . |
This comment was marked as resolved.
This comment was marked as resolved.
|
@RokeJulianLockhart Sure |
Updates the URI, in the `virtio-win.spec` file, to direct to `kvm-guest-drivers-windows/issues`, as virtio-win#114 (comment) advises. Signed-off-by: Mr. Beedell, Roke Julian Lockhart (RJLB) <wy46xghh@rokejulianlockhart.addy.io>
Updates the RPM specification URI to refer to this GitHub repository, rather than RedHat. I don't know whether a “Bug URL” key would also be useful.