Conversation
| @@ -0,0 +1 @@ | |||
| 49e9a28af998c2678e6651ad4e60a2dbba2f3d284f58b224b3382919c1de7d55 No newline at end of file | |||
There was a problem hiding this comment.
does it need this? can this be generated rather than checked in? or maybe its a random key?
There was a problem hiding this comment.
can you remove this and add any and all keys to the .gitignore ?
| print(" ERROR: Enter a valid email address (e.g. user@example.com).") | ||
|
|
||
| # --- password --- | ||
| password = prompt("Password", default="testuser123") |
There was a problem hiding this comment.
maybe this could be driven by a variable rather than hard coded (the default pw)
There was a problem hiding this comment.
can you move all the pw and login info into an .env file?
| @@ -0,0 +1,702 @@ | |||
| Image virtru-dsp-only-dsp Building | |||
There was a problem hiding this comment.
this looks liek logs? can be removed
There was a problem hiding this comment.
delete this .txt entirely, it shouldnt affect the build
| lastName: SecretUSA | ||
| email: aaa@secret.usa | ||
| credentials: | ||
| - value: testuser123 |
There was a problem hiding this comment.
re: the password from the script earlier. should be a variable.
might also be good to pick a default / creds that are a little safer. since this is public.
| TokenURL: "https://local-dsp.virtru.com:18443/auth/realms/opentdf/protocol/openid-connect/token", | ||
| }, | ||
| } | ||
| token, err := oauthCfg.PasswordCredentialsToken(ctx, "aaa@topsecret.usa", "testuser123") |
|
This new readme I presume was ai-generated or ai-assisted. It seems a little overly verbose, a little heavy to humanly consume, and could maybe be organized a little better. I have suggestions but they'd be better as a separate PR, which would make them easier to consume than PR comments. I will branch off this branch and create that PR |
2 participants
this is intended to be the initial impl deployed to main, but can't push directly to main so must go thru this PR