fix: resolve stale closure race condition in face scan timeout

[Janeeshareddy]

Fixes #1413

Root Cause

The original setTimeout inside startFaceDetection closed over step and faceDetected state values at creation time. Even when face detection succeeded and step transitioned to success, the timeout still saw stale values (step === 'scanning', faceDetected === false) and incorrectly fired the error state.

Changes

• Added timeoutRef (useRef) to store the 45s timeout ID explicitly
• Added scanActiveRef (useRef) to track if the scan session is still active
• Cleared timeout immediately inside handleFaceLogin when face is confirmed
• Added useEffect cleanup to cancel timeout on step change or component unmount
• Replaced stale state checks in timeout callback with scanActiveRef.current

Benefits

• Eliminates race condition from stale closures
• Prevents false error state after successful authentication
• Cleans up properly on unmount (no memory leaks)

[vercel]

@Janeeshareddy is attempting to deploy a commit to the CodeBlooded's projects Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions]

Hi @Janeeshareddy, thanks for contributing to Nyay Setu! 🎉

I have automatically:

• 👤 Assigned this PR to you.
• 🏷️ Applied the gssoc:approved label.

Our workflows will now analyze your changes to classify:

• 📈 PR Difficulty: level:*
• 🧩 PR Type: type:*
• 🌟 PR Quality: quality:*

Tip

Ensure your PR description references the issue it resolves (e.g. Closes #123). This allows the bot to inherit any additional labels from that issue!

Happy coding! 🚀

[viru0909-dev]

⚠️ Please Isolate Your Changes

Your fix for the face scan timeout bug using timeoutRef is correct and exactly what we need!

However, this PR accidentally includes over 700 lines of unrelated code for a new 'Lawyer Matching' feature (e.g., LawyerMatchingService, CaseAssignmentController, CaseAssignment.jsx).

Could you please clean up this branch so that it only includes the changes to FaceLoginModal.jsx? We can't merge the lawyer assignment logic as part of this bug fix.

[viru0909-dev]

PR contains unrelated files that have already been merged (e.g. CaseAssignmentController, LawyerMatchingService). Please rebase your branch on the latest main and only include the FaceLoginModal.jsx changes to resolve the timeout issue cleanly.