Skip to content

Fix deploy pipeline & new indexes #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vis97c merged 2 commits into from
Jun 30, 2026
Merged

Fix deploy pipeline & new indexes #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af104d9
Update deploy pipeline command
vis97c Jun 30, 2026
7edd503
fix linked query usage
vis97c Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
- name: "Deploy to Firebase"
uses: w9jds/firebase-action@master
with:
args: deploy --only functions
args: deploy --only functions,firestore --force
env:
GCP_SA_KEY: ${{ secrets.F_PRIVATE_KEY }}
PROJECT_ID: ${{ vars.F_PROJECT_ID }}
1 change: 1 addition & 0 deletions functions-scrapper/.npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
legacy-peer-deps=true
1 change: 1 addition & 0 deletions functions/.npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
legacy-peer-deps=true
7 changes: 3 additions & 4 deletions server/api/instance/notes/index.post.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,15 +71,14 @@ export default defineConditionallyCachedEventHandler(async (event) => {
// Public notes only
query = query.where("public", "==", true);

// Linked notes can only be public
if (linkedNoteSlug) {
// Same as /api/instance/notes/[noteSlug].post
const notesSnapshot = await firebaseFirestore
.collectionGroup("notes")
.where("instanceRef", "==", currentInstanceRef)
const linkedNotesSnapshot = await query
.where("slug", "==", linkedNoteSlug)
.limit(1)
.get();
const [snapshot] = notesSnapshot.docs;
const [snapshot] = linkedNotesSnapshot.docs;

// Check if linked note exists
if (!snapshot?.exists) {
Expand Down