Conversation
vischia
left a comment
vischia
left a comment
There was a problem hiding this comment.
Hi, I am taking the occasion for introducing you to the magic world of PR reviews 💃
You will hate me, but then when you will have to make a PR to code freaks (I mean to semi-professional software engineers) you will be already in control of good commit practices ;)
|
|
||
| std::vector<ttH::Dilepton> ll; | ||
| std::vector<ttH::DileptonMet> llmet; | ||
| std::vector<ttH::Dijet> jj; |
There was a problem hiding this comment.
It is usually desirable to not have whiteline removed/added without a specific reason.
I am usually personally quite indifferent to that, but there are very picky persons here and there :)
The general idea is that if you don't really need to remove/add a whiteline there, then there is no reason for having it.
| #include <cp3_llbb/Framework/interface/HLTProducer.h> | ||
|
|
||
| #include <cmath> | ||
|
|
There was a problem hiding this comment.
Again, whiteline should be added back
| #define ttH_GEN_DEBUG (false) | ||
| #define TT_GEN_DEBUG (false) | ||
|
|
||
|
|
There was a problem hiding this comment.
No reason to add a whiteline here
| jj.clear(); | ||
| //llmetjj.clear(); | ||
| //llmetjj_cmva.clear(); | ||
|
|
| if (allelectrons.p4[ielectron].Pt() > m_subleadingElectronPtCut | ||
| && fabs(allelectrons.p4[ielectron].Eta()) < m_electronEtaCut) | ||
| { | ||
|
|
| leptons.push_back(ele); | ||
| //selElectrons.push_back(ele); | ||
| } | ||
|
|
| int nElectrons=leptons.size(); | ||
| //std::cout<<" # of ele: "<< nElectrons <<std::endl; | ||
| if(nElectrons!=1) return; | ||
|
|
| //int nMuons=selMuons.size(); | ||
| // if(nMuons!=1) continue; | ||
| }//end of loop on muons | ||
|
|
| @@ -30,7 +30,7 @@ | |||
| enable = cms.bool(True), | |||
| categories_parameters = cms.PSet( | |||
| # Per-category lepton pt cuts | |||
There was a problem hiding this comment.
Well, I don't understand this commit. I don't remember I touched that intentionally :)
| muonEtaCut = cms.untracked.double(2.4), | ||
| electrons_loose_wp_name = cms.untracked.string("cutBasedElectronID-Summer16-80X-V1-loose"), | ||
| #electrons_loose_wp_name = cms.untracked.string("cutBasedElectronID-Summer16-80X-V1-loose"), #old working point | ||
|
|
2 participants
No description provided.