Added ability to copy/deepcopy events#81
Open
emshotton wants to merge 5 commits intovishnubob:masterfrom
Open
Conversation
…setters with @Property decorator and removed __slots__ on some event classes, fixes vishnubob#60, vishnubob#40
Author
|
Looks like the Travis CI build is failing due to a permissions issue?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the ace library. This refactors the Event classes to allow copy/deepcopy of events. As a consequence it removes some slots from a bunch of events. It's at the limit of my python knowledge, but I don't think should be a performance hit as the memory for the properties being get/set is in the already existing data property (which is still defined in slots), so the slots weren't being used.