Eliminate corruption when writing MIDIs due to RunningStatus#82
Open
MrCheeze wants to merge 1 commit intovishnubob:masterfrom
Open
Eliminate corruption when writing MIDIs due to RunningStatus#82MrCheeze wants to merge 1 commit intovishnubob:masterfrom
MrCheeze wants to merge 1 commit intovishnubob:masterfrom
Conversation
…sting even after a MetaEvent/SysexEvent is seen.
Author
|
Incidentally, I notice the python3 branch instead opts to eliminate the use of RunningStatus entirely, with the following comment:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When writing midis, a running state is used so that if multiple messages of the same type are used in a row, the message type only has to be specified once. This is fine, except for the fact that MetaEvents and SysexEvents does not cause the state to reset. This can cause the generated midis to be unreadable by some (but not all) software, so here's a quick fix.