feat: add visual feedback when profile link is copied#98
feat: add visual feedback when profile link is copied#98aditya2206-afk wants to merge 4 commits into
Conversation
|
@aditya2206-afk is attempting to deploy a commit to the vishnukothakapu's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughLinkIdCard and LinkItem convert their copy handlers to async/await with try/catch, write full ChangesClipboard Error Handling with User Feedback
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/dashboard/LinkIdCard.tsx`:
- Line 18: The clipboard copy currently writes a scheme-less URL; update the
navigator.clipboard.writeText call in LinkIdCard.tsx (the place where you build
the profile link) to copy a fully-qualified URL by prepending the scheme (e.g.,
"https://") so it writes "https://linkid.qzz.io/${username}" instead of
"linkid.qzz.io/${username}".
In `@app/dashboard/LinkItem.tsx`:
- Around line 41-43: The copy action currently writes a scheme-less path via
navigator.clipboard.writeText(`linkid.qzz.io/${username}/${link.platform}`); —
change it to write a full URL by prepending the scheme (e.g. use
`https://linkid.qzz.io/${username}/${link.platform}`) so pasted output is
clickable; update the code in LinkItem.tsx where navigator.clipboard.writeText
is called and ensure the template uses the existing username and link.platform
variables unchanged.
- Around line 113-126: The JSX in the LinkItem component nests a <Button> inside
an <a>, which is invalid; change to render the <Button> with asChild and place
the <a> as the child so the anchor becomes the actual interactive element.
Specifically, in the block using link.url / link.label / link.platform and the
ExternalLink icon, replace the outer <a> wrapping the <Button> with <Button
asChild> and move href, target, rel, aria-label (and any link-specific props)
onto the inner <a> so the anchor receives those attributes while the Button
styles/behavior are preserved; keep title and the ExternalLink element as
before. Ensure you update the JSX in the LinkItem component (the fragment using
Button, ExternalLink, and link.url/link.label/link.platform) accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 301077c8-8442-4f69-a09b-a0fd4c4cf8cd
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (2)
app/dashboard/LinkIdCard.tsxapp/dashboard/LinkItem.tsx
|
Thanks for the review ✅ Updated the copy actions to use fully-qualified URLs (https://) and refactored nested interactive elements using the Please let me know if any further changes are needed. |
|
All issues fixed. Ready for review. Please approve workflow and merge. |
|
Thanks for pointing that out ✅ Removed duplicate URL argument and corrected the nested button structure. Everything should now follow proper accessibility and clipboard usage. Please let me know if anything else needs refinement. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@vishnukothakapu (or @aparna24bce11388 if they are the primary maintainer) Hi, it looks like the Could you please take a look at this? If it's a non-blocking check, or if you can adjust the workflow permissions, the PR should be ready for merge. Thanks for your time and guidance! |
|
✅ All checks (except Copilot permission issue) have passed. Kindly review and merge the PR when possible. Thank you! |
|
Hi @aditya2206-afk, the Copilot review error is from our workflow side, not from your PR. Your PR looks good and the required checks have passed successfully. Please wait for the mentor review. Once the mentor review is completed, the PR will be merged. |
|
Hi @aditya2206-afk, could you please resolve the merge conflicts as well? |
|
✅ Merge conflicts resolved successfully. Kindly review and merge the PR when possible. Thank you! |
|
✅ All checks are passing and conflicts resolved. Kindly merge when possible. Thank you! |
Hi @aditya2206-afk, Please wait for the mentor review. Once the mentor review is completed, the PR will be merged. |
|
hey @aditya2206-afk. pls review ur pr again: 1.the last commit deleted the package-lock.json file |
|
@aditya2206-afk any updates? |
|
hi @aditya2206-afk. pls update your progress and resolve conflicts |
|
Hi @aditya2206-afk , |
|
hey @aditya2206-afk. Pls resolve conflicts |
|
Hey @aditya2206-afk! Saw your work on GSSoC 2026. We are building TermUI, a TypeScript terminal UI framework with React-style hooks and JSX, rendered entirely in the terminal. We have 99 unassigned GSSoC issues open, including new widgets, hooks, and CLI tooling. Your TypeScript background transfers directly. Karanjot, TermUI maintainer |
|
hey @aditya2206-afk. pls resolve conflicts |
Fixes #94
Description
Added visual feedback when the profile link is copied.
Changes Made
GSSoC
Participant
Summary by CodeRabbit
Bug Fixes
Improvements
UI
Accessibility