Copilot/add data driven unit tests

[visionarycoder]

No description provided.

[Copilot]

Pull Request Overview

This PR involves a major refactoring to add data-driven unit test patterns to the VisionaryCoder proxy framework. The changes include removing legacy .NET 10 configuration files, implementing a comprehensive storage and secrets management system, adding primitive types with JSON/EF Core support, establishing pagination and querying capabilities, and creating extensive utility extensions.

Key Changes:

• Removed all existing proxy infrastructure files (abstractions, implementations, interceptors, and DI configuration)
• Added comprehensive storage providers (local, FTP, Azure Blob) with secret management integration
• Implemented EntityId primitive type system with serialization and ORM support
• Created extensive utility extensions for collections, types, dates, and CLI operations

Reviewed Changes

Copilot reviewed 298 out of 541 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/net10.0/Directory.Build.props	Removed legacy .NET 10 build configuration
src/VisionaryCoder.Proxy/*	Removed existing proxy client and pipeline infrastructure
src/VisionaryCoder.Framework/Storage/*	Added comprehensive storage abstraction with local, FTP, and Azure providers
src/VisionaryCoder.Framework/Primitives/*	Added EntityId type system with JSON and EF Core integration
src/VisionaryCoder.Framework/Extensions/*	Added extensive utility extensions for various data types
src/VisionaryCoder.Framework/Configuration/*	Added local and Azure configuration providers

Comments suppressed due to low confidence (1)

src/VisionaryCoder.Framework/Extensions/EnumerableExtensions.cs:1

• The code structure is incorrect - there are misplaced braces and the collection variable is used outside its scope on line 176. The logic should be properly structured within the source != null check.

using System.Collections.ObjectModel;

[Copilot]

The ArgumentNullException.ThrowIfNullOrWhiteSpace calls are using nameof() incorrectly - they should use the actual property values, not the property names.

Suggested change

	ArgumentNullException.ThrowIfNullOrWhiteSpace(nameof(Host));
	ArgumentNullException.ThrowIfNullOrWhiteSpace(nameof(Username));
	ArgumentNullException.ThrowIfNullOrWhiteSpace(nameof(Password));
	ArgumentNullException.ThrowIfNullOrWhiteSpace(Host, nameof(Host));
	ArgumentNullException.ThrowIfNullOrWhiteSpace(Username, nameof(Username));
	ArgumentNullException.ThrowIfNullOrWhiteSpace(Password, nameof(Password));

[Copilot]

The method is missing the closing separator call and closing '--' line that were present before the refactoring, creating an incomplete display format.

Suggested change

	Console.WriteLine($"-- {appName}");
	Console.WriteLine($"-- {appName}");
	Console.WriteLine($"--");
	ShowSeparator(separateWidth);

[Copilot]

The modulo operation should use 12, not 13, since there are only 12 months (ordinals 1-12). Using % 13 will never trigger the modulo for month 12.

Suggested change

	return new Month((month.Ordinal + 1) % 13);
	return new Month((month.Ordinal + 1) % 12);

[Copilot]

Missing validation for empty Children collection. If cf.Children is empty, the Select().Join() operations could produce unexpected results or throw exceptions.

Suggested change

	if (cf.Operator == "And")
	return cf.Children.Select(c => c.ToQueryFilter<T>()).Join(useAnd: true);
	if (cf.Operator == "Or")
	return cf.Children.Select(c => c.ToQueryFilter<T>()).Join(useAnd: false);
	if (cf.Operator == "And")
	{
	if (cf.Children == null || cf.Children.Count == 0)
	throw new InvalidOperationException("Composite 'And' filter must have at least one child.");
	return cf.Children.Select(c => c.ToQueryFilter<T>()).Join(useAnd: true);
	}
	if (cf.Operator == "Or")
	{
	if (cf.Children == null || cf.Children.Count == 0)
	throw new InvalidOperationException("Composite 'Or' filter must have at least one child.");
	return cf.Children.Select(c => c.ToQueryFilter<T>()).Join(useAnd: false);
	}