Add quickjs-ng 0.14.0#391
Open
rompelhd wants to merge 2 commits into
Open
Conversation
rompelhd
commented
May 18, 2026
rompelhd
commented
- VITABUILD for quickjs-ng 0.14.0
isage
reviewed
May 18, 2026
| package() { | ||
| cd quickjs-$pkgver/build | ||
|
|
||
| install -Dm644 libqjs.a \ |
Contributor
There was a problem hiding this comment.
Why?
quickjs cmake has install targets (that also installs cmake config)
Author
There was a problem hiding this comment.
I compiled the QuickJS core and performed the installation manually because the default configuration enabled the CLI binaries, which caused errors related to ioctl.h.
d3m3vilurr
reviewed
May 19, 2026
|
|
||
| install -Dm644 ../quickjs.h \ | ||
| "$pkgdir$VITASDK/arm-vita-eabi/include/quickjs.h" | ||
| touch qjs qjsc # fake binaries, Vita will never use them. |
Contributor
There was a problem hiding this comment.
rm them is better. isn't it?
Contributor
There was a problem hiding this comment.
No, this is for cmake install step to not fail. rm can be done afterwards, though (on the other hand, maybe patching cmakelists to not try to install them in the first place is better)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.