Skip to content

Update install-vitasdk.sh to check for arch on Linux #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joel16 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update install-vitasdk.sh to check for arch on Linux #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion include/install-vitasdk.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,13 @@ install_vitasdk () {
sudo mkdir -p $INSTALLDIR
sudo chown $USER:$(id -gn $USER) $INSTALLDIR
fi
wget -O- "$(get_download_link master linux)" | tar xj -C $INSTALLDIR --strip-components=1

# Check if architecture is aarch64 (ARM 64-bit)
if [ "$(uname -m)" == "aarch64" ]; then
wget -O- "$(get_download_link master linux-arm64)" | tar xj -C $INSTALLDIR --strip-components=1
else
wget -O- "$(get_download_link master linux)" | tar xj -C $INSTALLDIR --strip-components=1
Copy link
Copy Markdown
Contributor

@d3m3vilurr d3m3vilurr Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember that when I first read this patch, I'm worried that a script can download aarch64 version on linux x86_64

so, safe way is, we should split type linux-arm64 and linux-x86_64.
but for backward compatibility, it should be.. linux-v2 (cuz a tag would be master-linux-v2.4321)

Suggested change
wget -O- "$(get_download_link master linux)" | tar xj -C $INSTALLDIR --strip-components=1
wget -O- "$(get_download_link master linux-v2)" | tar xj -C $INSTALLDIR --strip-components=1

fi
;;

MSYS*|MINGW64*)
Expand Down