Conversation
vitaut
requested changes
Sep 2, 2026
Comment on lines
+1
to
+3
| cmake_minimum_required(VERSION 3.16) | ||
| project(zmij CXX C) | ||
|
|
Owner
There was a problem hiding this comment.
This is incorrect: test is a subdirectory, not a subproject.
Comment on lines
+55
to
+57
| if (MSVC) | ||
| message(STATUS "Skipping zmij-c-test on MSVC due to C compiler limitations with complex initializers") | ||
| else () |
Owner
There was a problem hiding this comment.
We shouldn't be disabling tests. If there is a problem, please submit an issue or, better, a PR to fix it.
Comment on lines
+20
to
+21
| # Link against the zmij library and test helpers. | ||
| target_link_libraries(${name} PRIVATE dragonbox gtest fmt zmij) |
Owner
There was a problem hiding this comment.
This is incorrect for implementation tests, please revert.
| add_executable(float-check float-check.cc) | ||
| target_compile_features(float-check PRIVATE ${ZMIJ_CHECK_STANDARD}) | ||
| target_link_libraries(float-check fmt dragonbox zmij) | ||
| target_link_libraries(float-check PRIVATE fmt dragonbox zmij) |
Owner
There was a problem hiding this comment.
I don't think we need PRIVATE for binaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.