Make tests and example optional - #153
Conversation
|
Thanks for the PR but could you provide some details about the motivation? |
Thanks for the review. The main motivation is to make zmij available through vcpkg so that users can install and integrate it more easily. When zmij is consumed as a library, users should not be required to build its tests and examples. These options allow package managers and downstream projects to disable them, much like the |
| option(ZMIJ_BUILD_TESTS "Build tests" ON) | ||
| option(ZMIJ_BUILD_EXAMPLES "Build examples" ON) |
There was a problem hiding this comment.
Let's rename to ZMIJ_TEST and ZMIJ_EXAMPLE to follow fmt's convention and since this is about generating targets, not building. And update the descriptions accordingly, e.g. "Generate the test targets"
971d624 to
acc64fd
Compare
|
Merged, thank you |
Follow-up to #149.