feat(core): render group dock accentColor on group button and popover - #509
Merged
Conversation
Reads the new @devframes/hub@0.8.0 DevframeViewGroup.accentColor field and applies it to the group button, its popover, and the sidebar variant, falling back to the existing default styling when unset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
@devframes/hub(already pinned at0.8.0viacatalog:deps) added an optionalaccentColortoDevframeViewGroup— see devframes/devframe@191e81c. Its doc comment says the viewer may use it to style the group button and/or its popover, falling back to default styling when unset. This wires that field through the rendering path in@vitejs/devtools:accent-color.ts, small:style-object helpers (accentTextStyle,accentActiveStyle) for an arbitrary runtime color, mirroring the existinggetHashColorFromString/HashBadgepattern for colors that can't become build-time UnoCSS classes.DockEntry.vueaccepts an optionalaccentColorprop, applied only while selected.DockGroupButton.vueforwardsgroup.accentColorto the underlyingDockEntry(top-bar group button).DockGroupPopover.vueaccents its header and the selected member row.DockGroupSidebar.vueaccents the group anchor icon, a selected member button, and the "show more" overflow button, for the vertical-rail variant.All fall back to the existing default Uno classes (
text-primary/bg-active) exactly whenaccentColoris unset.Linked Issues
Additional context
Verified with
pnpm typecheck,eslinton the touched files, and the fullpnpm testsuite (all passing) — no new tests added since this is pure inline-style/rendering wiring behind an already-typed optional field, with no new branching logic beyond the existing fallback convention.Created with the help of an agent.