Skip to content

fix(core): define Vue feature flags for non-Vue hosts - #514

Open
webfansplz wants to merge 1 commit into
mainfrom
fix/vue-feature-flags
Open

fix(core): define Vue feature flags for non-Vue hosts#514
webfansplz wants to merge 1 commit into
mainfrom
fix/vue-feature-flags

Conversation

@webfansplz

Copy link
Copy Markdown
Member

Fix #513

Copilot AI lite review requested due to automatic review settings August 4, 2026 14:11
@pkg-pr-new

pkg-pr-new Bot commented Aug 4, 2026

Copy link
Copy Markdown

Open in StackBlitz

@vitejs/devtools

npm i https://pkg.pr.new/@vitejs/devtools@514

@vitejs/devtools-kit

npm i https://pkg.pr.new/@vitejs/devtools-kit@514

@vitejs/devtools-oxc

npm i https://pkg.pr.new/@vitejs/devtools-oxc@514

@vitejs/devtools-rolldown

npm i https://pkg.pr.new/@vitejs/devtools-rolldown@514

@vitejs/devtools-vite

npm i https://pkg.pr.new/@vitejs/devtools-vite@514

@vitejs/devtools-vitest

npm i https://pkg.pr.new/@vitejs/devtools-vitest@514

commit: 513287a

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses #513 by ensuring Vue ESM-bundler feature flags are explicitly defined by the DevTools injection plugin when running in non-Vue hosts, preventing the browser console warning about missing __VUE_* compile-time flags.

Changes:

  • Add a config() hook to DevToolsInjection that provides default values for Vue feature flags when not already defined by the host.
  • Add Vitest coverage validating the default flag definitions and host-defined overrides.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/core/src/node/plugins/injection.ts Injects default define values for Vue feature flags during serve to suppress Vue’s missing-feature-flags warning.
packages/core/src/node/plugins/tests/injection.test.ts Adds tests validating default Vue flag definitions and preserving host-provided flag values.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/core/src/node/plugins/injection.ts
Comment thread packages/core/src/node/plugins/__tests__/injection.test.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vue warning in console

2 participants