fix(core): define Vue feature flags for non-Vue hosts - #514
Open
webfansplz wants to merge 1 commit into
Open
Conversation
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-oxc
@vitejs/devtools-rolldown
@vitejs/devtools-vite
@vitejs/devtools-vitest
commit: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses #513 by ensuring Vue ESM-bundler feature flags are explicitly defined by the DevTools injection plugin when running in non-Vue hosts, preventing the browser console warning about missing __VUE_* compile-time flags.
Changes:
- Add a
config()hook toDevToolsInjectionthat provides default values for Vue feature flags when not already defined by the host. - Add Vitest coverage validating the default flag definitions and host-defined overrides.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/core/src/node/plugins/injection.ts | Injects default define values for Vue feature flags during serve to suppress Vue’s missing-feature-flags warning. |
| packages/core/src/node/plugins/tests/injection.test.ts | Adds tests validating default Vue flag definitions and preserving host-provided flag values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #513