Skip to content

fix(chat): complete conversationId handling for assistant SSE - #117

Merged
vitorhugo-dotnet merged 5 commits into
mainfrom
fix/116-assistant-conversation-id-guard
Sep 18, 2026
Merged

vitorhugo-dotnet merged 5 commits into
mainfrom
fix/116-assistant-conversation-id-guard

Conversation

@vitorhugo-dotnet

@vitorhugo-dotnet vitorhugo-dotnet commented Sep 18, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • validate conversationId before dispatching the assistant SSE request
  • regenerate invalid persisted conversation IDs while preserving local message history
  • surface HTTP/request failures separately from streamed provider failures
  • make the frontend mock enforce the same conversationId contract as the backend
  • cover first/subsequent messages, invalid persisted conversation state, and HTTP validation failures

Verification

  • TDD RED confirmed the two missing behaviors before the production fix
  • Playwright: 76 passed
  • Production build: passed (tsc -b && vite build)
  • Final diff reviewed: 5 files, scoped to assistant conversation handling/tests

Fixes #116

@vitorhugo-dotnet
vitorhugo-dotnet marked this pull request as ready for review September 18, 2026 00:21
@vitorhugo-dotnet
vitorhugo-dotnet merged commit 7657295 into main Sep 18, 2026
6 checks passed
@vitorhugo-dotnet
vitorhugo-dotnet deleted the fix/116-assistant-conversation-id-guard branch September 18, 2026 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(chat): send and persist conversationId when using assistant SSE endpoint

1 participant