Repository navigation
feat(ai): add conversation memory to Ask ApplyWell - #94
Merged
Merged
Conversation
Qodana for JVM3 new problems were found
View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2025.3.2
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #93 using Spring AI native chat memory so Ask ApplyWell can resolve follow-up questions from the active conversation context.
Implementation
conversationId: UUIDtoAssistantChatRequestMessageChatMemoryAdvisorwithMessageWindowChatMemoryChatMemory.CONVERSATION_IDon every assistant request<userId>:<conversationId>to prevent cross-user leakageapp.assistant.memory-max-messagestoken,error,complete)Verification
TDD cycle was exercised explicitly:
mvn -B -ntp clean verify: 425 tests, 0 failures, 0 errors, BUILD SUCCESSAssistantConversationMemoryTest: 6/6 passingThe Qodana PR comment lists three repository-wide warnings. This workflow uses
pr-mode: false, and the same three warnings were already reported on the initial test-only RED commit, so they are not introduced by the production implementation in this PR.Covered scenarios
conversationIdretains previous user/assistant turnsPersistence
This PR intentionally uses Spring AI's in-memory repository. Persistence across application restarts or multiple backend replicas was optional in #93 and is not required for the current deployment. The
ChatMemoryabstraction keeps a future move toJdbcChatMemoryRepositoryisolated from the HTTP contract.Closes #93