fix(assistant): negotiate structured errors before SSE starts - #97
Merged
Merged
Conversation
10 tasks
Qodana for JVM3 new problems were found
View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2025.3.2
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the backend side of #96.
Root cause
POST /api/v1/assistant/chatproducestext/event-stream, but validation and malformed-body errors happen before the controller returns anSseEmitter. The global exception handlers did not declare JSON/problem media types, so the original 400 could cascade intoHttpMediaTypeNotAcceptableExceptionwhen the client negotiated SSE.Changes
@NotNull conversationIdand@NotBlank messageapplication/problem+jsonandapplication/jsonfor:MethodArgumentNotValidExceptionHttpMessageNotReadableExceptionRelated frontend fix: companion PR in
React-JobApplyTracker.Fixes #96