Repository navigation
Add feature flags and isolated WebSocket media forwarding - #61
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e90867c95f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Discord Activity cannot construct RTCPeerConnection, it can now receive encoded H.264/Opus through a separate WebSocket forwarding service. RelayControl issues scoped, single-use grants and renewable leases; the forwarder copies encoded media without transcoding and bounds queues, connections and messages.
Registers Microsoft.FeatureManagement with PublicRooms, DiscordActivity, DuplexAudio and ScreenShare enabled by default. DiscordWebSocketMedia defaults to false. Endpoint and background-service gates preserve existing TURN/signaling, session cleanup and desktop fallback behavior. Adds a separate opt-in Docker profile/image and service credential.
Validation: API solution restore/build succeeded with zero warnings/errors; all 339 tests passed, including real WebSocket forwarding, lease/reconnect/expiry fencing, feature gates and slow-viewer isolation. Release publish and Compose configuration validation passed. Native Edge fixture decoded forwarded H.264/Opus.
Runtime limits: no Docker image/container execution (daemon unavailable), production deployment or live Discord/capture verification. The in-memory forwarding registry requires one instance. Keep the new flag disabled until live rollout validation.
Companion PRs: RelayControl #61, FrameRelay #45, Activity #9. Deploy the companion components together before enabling the new flags.