Skip to content

fix(install.sh): use 'clawmetry onboard' instead of legacy 'setup'#894

Open
vivekchand wants to merge 1 commit intomainfrom
fix/e2e-install-sh-onboard-command-20260506
Open

fix(install.sh): use 'clawmetry onboard' instead of legacy 'setup'#894
vivekchand wants to merge 1 commit intomainfrom
fix/e2e-install-sh-onboard-command-20260506

Conversation

@vivekchand
Copy link
Copy Markdown
Owner

Summary

  • Replace clawmetry setup calls in install.sh with clawmetry onboard (and update the comment to match)
  • Aligns the actual command with the script's own user-facing strings (CLAWMETRY_SKIP_ONBOARD, "Skipping onboard...") and the documented entry point referenced by the cli help

Why

The E2E health check expects clawmetry onboard to appear in install.sh as the canonical first-time-setup command. The script was invoking the legacy alias setup instead, while still saying "onboard" in messages — confusing for users reading the install output, and a fail in the automated health probe.

Both setup and onboard are registered subparsers and resolve to the same handler today, so this change is functionally a no-op for end-users. It just removes the inconsistency.

Test plan

  • curl -fsSL https://clawmetry.com/install.sh | grep -c 'clawmetry onboard' → returns >= 1 (was 0)
  • Fresh install on Linux + macOS still completes onboarding
  • NemoClaw path still skipped via CLAWMETRY_SKIP_ONBOARD / sandbox detection

🤖 Detected by ClawMetry E2E Health & Auto-Fix cron

The install script invoked the legacy `clawmetry setup` command while the
user-facing strings (CLAWMETRY_SKIP_ONBOARD, "Skipping onboard...") and the
canonical first-time-setup subcommand are 'onboard'. This aligns the actual
command with the script's own language and the documented entry point.

Both `setup` and `onboard` resolve to the same handler today, so this is a
no-op for users; it removes inconsistency and matches the E2E health check
that asserts install.sh references `clawmetry onboard`.
Copy link
Copy Markdown
Owner Author

@vivekchand vivekchand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test plan & review notes

Repo: vivekchand/clawmetry

What changed

  • install.sh: replaced "$CLAWMETRY_BIN" setup (two call sites) and the section comment with onboard, aligning the actual invocation with the surrounding messaging (CLAWMETRY_SKIP_ONBOARD, "Skipping onboard…") and the CLI's canonical subcommand.

Smoke commands

  • bash install.sh on a fresh environment — verify clawmetry onboard is invoked (not setup)
  • Check CI install-test.yml still passes for all 3 OS targets

Likely failure modes from the diff

  • Other call sites not updated: search the repo for any remaining clawmetry setup or $CLAWMETRY_BIN setup references (docs, CI scripts, cli.py help text, CHANGELOG.md examples) that still point users at the legacy alias — they'd work today but will break if setup is eventually removed.
  • setup alias lifespan: the PR body notes both subparsers resolve to the same handler "today" — if setup is ever dropped from cli.py, any cached/mirrored copies of the old install.sh (CDN, package mirrors) would regress. Worth tracking with a deprecation notice in cli.py.
  • </dev/tty path vs. non-TTY path: the fix is symmetric across both branches, which looks correct — no risk of one path still calling setup.
  • CI matrix coverage: install-test.yml runs cross-platform smoke tests; confirm the job actually exercises the onboarding branch (i.e., CLAWMETRY_SKIP_ONBOARD is not set globally in CI, which would silently skip the changed lines).

Note

  • This appears to be the canonical replacement for #793 (which covers the same setuponboard rename). If #793 is safe to close, that would keep the queue tidy.

Generated by Claude Code

Copy link
Copy Markdown
Owner Author

Test plan & review notes

Repo: vivekchand/clawmetry

What changed

  • install.sh: replaces clawmetry setup with clawmetry onboard (1 file, +3/-3); aligns the script's command with its own user-facing strings (CLAWMETRY_SKIP_ONBOARD, "Skipping onboard…") and the E2E health probe expectation

Smoke commands

  • bash install.sh on Linux and macOS — confirm onboarding completes end-to-end
  • CLAWMETRY_SKIP_ONBOARD=1 bash install.sh — confirm skip path still works
  • grep -c 'clawmetry onboard' install.sh → should return ≥ 1 (the E2E probe check)

Likely failure modes from the diff

  • Both setup and onboard resolve to the same handler today — purely cosmetic, no functional regression expected. Smoke test is mainly a confidence check that the install path doesn't break on a net-new machine.

Issue link

  • No Closes #N — auto-generated by ClawMetry E2E Health & Auto-Fix cron. If there's a tracking issue, linking it would help.

Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant