fix(install.sh): use 'clawmetry onboard' instead of legacy 'setup'#894
Open
vivekchand wants to merge 1 commit intomainfrom
Open
fix(install.sh): use 'clawmetry onboard' instead of legacy 'setup'#894vivekchand wants to merge 1 commit intomainfrom
vivekchand wants to merge 1 commit intomainfrom
Conversation
The install script invoked the legacy `clawmetry setup` command while the user-facing strings (CLAWMETRY_SKIP_ONBOARD, "Skipping onboard...") and the canonical first-time-setup subcommand are 'onboard'. This aligns the actual command with the script's own language and the documented entry point. Both `setup` and `onboard` resolve to the same handler today, so this is a no-op for users; it removes inconsistency and matches the E2E health check that asserts install.sh references `clawmetry onboard`.
2 tasks
vivekchand
commented
May 7, 2026
Owner
Author
vivekchand
left a comment
There was a problem hiding this comment.
Test plan & review notes
Repo: vivekchand/clawmetry
What changed
install.sh: replaced"$CLAWMETRY_BIN" setup(two call sites) and the section comment withonboard, aligning the actual invocation with the surrounding messaging (CLAWMETRY_SKIP_ONBOARD, "Skipping onboard…") and the CLI's canonical subcommand.
Smoke commands
bash install.shon a fresh environment — verifyclawmetry onboardis invoked (notsetup)- Check CI
install-test.ymlstill passes for all 3 OS targets
Likely failure modes from the diff
- Other call sites not updated: search the repo for any remaining
clawmetry setupor$CLAWMETRY_BIN setupreferences (docs, CI scripts,cli.pyhelp text,CHANGELOG.mdexamples) that still point users at the legacy alias — they'd work today but will break ifsetupis eventually removed. setupalias lifespan: the PR body notes both subparsers resolve to the same handler "today" — ifsetupis ever dropped fromcli.py, any cached/mirrored copies of the oldinstall.sh(CDN, package mirrors) would regress. Worth tracking with a deprecation notice incli.py.</dev/ttypath vs. non-TTY path: the fix is symmetric across both branches, which looks correct — no risk of one path still callingsetup.- CI matrix coverage:
install-test.ymlruns cross-platform smoke tests; confirm the job actually exercises the onboarding branch (i.e.,CLAWMETRY_SKIP_ONBOARDis not set globally in CI, which would silently skip the changed lines).
Note
- This appears to be the canonical replacement for #793 (which covers the same
setup→onboardrename). If #793 is safe to close, that would keep the queue tidy.
Generated by Claude Code
Owner
Author
Test plan & review notesRepo: vivekchand/clawmetry What changed
Smoke commands
Likely failure modes from the diff
Issue link
Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clawmetry setupcalls ininstall.shwithclawmetry onboard(and update the comment to match)CLAWMETRY_SKIP_ONBOARD, "Skipping onboard...") and the documented entry point referenced by the cli helpWhy
The E2E health check expects
clawmetry onboardto appear ininstall.shas the canonical first-time-setup command. The script was invoking the legacy aliassetupinstead, while still saying "onboard" in messages — confusing for users reading the install output, and a fail in the automated health probe.Both
setupandonboardare registered subparsers and resolve to the same handler today, so this change is functionally a no-op for end-users. It just removes the inconsistency.Test plan
curl -fsSL https://clawmetry.com/install.sh | grep -c 'clawmetry onboard'→ returns >= 1 (was 0)CLAWMETRY_SKIP_ONBOARD/ sandbox detection🤖 Detected by ClawMetry E2E Health & Auto-Fix cron