Fix semantics of posix time function by zhanghe-vivo · Pull Request #240 · vivoblueos/kernel

zhanghe-vivo · 2025-12-22T03:56:34Z

signal process hasn't added, will rebase #238

lawkai-vivo · 2025-12-22T07:36:38Z

Can you elaborate why do we need to invent a new POSIX timer in kernel rather than using soft timer?

zhanghe-vivo · 2025-12-29T02:09:20Z

stub posix timers, preserve clock implement

zhanghe-vivo · 2026-01-05T09:01:24Z

build_prs #240 vivoblueos/librs#22 vivoblueos/libc#5

github-actions · 2026-01-05T09:02:59Z

Job is started, see https://github.com/vivoblueos/kernel/actions/runs/20710231867.

github-actions · 2026-01-05T09:16:09Z

❌ Job failed. Failed jobs: check_format (failure), build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/20710231867.

zhanghe-vivo · 2026-01-05T09:18:29Z

build_prs #240 vivoblueos/librs#22 vivoblueos/libc#5

github-actions · 2026-01-05T09:19:30Z

Job is started, see https://github.com/vivoblueos/kernel/actions/runs/20710672760.

github-actions · 2026-01-05T09:23:33Z

❌ Job failed. Failed jobs: build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/20710672760.

zhanghe-vivo · 2026-01-05T09:24:38Z

build_prs #240 vivoblueos/librs#22 vivoblueos/libc#5

github-actions · 2026-01-05T09:25:42Z

Job is started, see https://github.com/vivoblueos/kernel/actions/runs/20710835888.

github-actions · 2026-01-05T09:30:16Z

❌ Job failed. Failed jobs: build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/20710835888.

zhanghe-vivo · 2026-01-05T09:48:12Z

build_prs #240 vivoblueos/librs#22 vivoblueos/libc#5

github-actions · 2026-01-05T09:49:16Z

Job is started, see https://github.com/vivoblueos/kernel/actions/runs/20711463695.

github-actions · 2026-01-05T09:52:43Z

❌ Job failed. Failed jobs: build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/20711463695.

zhanghe-vivo · 2026-01-05T09:58:08Z

build_prs #240 vivoblueos/librs#22 vivoblueos/libc#5

github-actions · 2026-01-05T09:59:13Z

Job is started, see https://github.com/vivoblueos/kernel/actions/runs/20711707723.

github-actions · 2026-01-05T10:09:31Z

❌ Job failed. Failed jobs: build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/20711707723.

zhanghe-vivo · 2026-01-05T10:15:30Z

build_prs #240 vivoblueos/librs#22 vivoblueos/libc#5

github-actions · 2026-01-05T10:16:32Z

Job is started, see https://github.com/vivoblueos/kernel/actions/runs/20712177870.

github-actions · 2026-01-05T10:25:14Z

✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/20712177870.

zhanghe-vivo · 2026-01-05T10:28:10Z

build_prs #240 vivoblueos/librs#22 vivoblueos/libc#5

github-actions · 2026-01-05T10:29:21Z

Job is started, see https://github.com/vivoblueos/kernel/actions/runs/20712502352.

github-actions · 2026-01-05T10:38:35Z

✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/20712502352.

github-actions · 2026-02-25T08:25:32Z

❌ Job failed. Failed jobs: build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/22388379202.

zhanghe-vivo · 2026-02-25T08:26:30Z

build_prs #240 vivoblueos/librs#22 vivoblueos/libc#5

github-actions · 2026-02-25T08:27:35Z

Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22388526351.

github-actions · 2026-02-25T08:36:16Z

❌ Job failed. Failed jobs: check_format (failure), see https://github.com/vivoblueos/kernel/actions/runs/22388526351.

zhanghe-vivo · 2026-02-25T08:51:01Z

build_prs #240 vivoblueos/librs#22 vivoblueos/libc#5

github-actions · 2026-02-25T08:52:06Z

Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22389341686.

github-actions · 2026-02-25T09:00:53Z

✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/22389341686.

han-jiang277 · 2026-03-02T09:57:00Z

kernel/src/syscall_handlers/posix_timers.rs

+    if !evp.is_null() {
+        return -EINVAL as c_long;
+    }
+    unsafe { *timerid = 1 as timer_t };


If not fully implemented, it is recommended to add a TODO marker.

chang as suggestion

han-jiang277 · 2026-03-02T10:03:52Z

kernel/src/syscall_handlers/posix_timers.rs

+
+// Global realtime offset.
+use crate::sync::spinlock::SpinLock;
+static REALTIME_OFFSET_NS: SpinLock<i64> = SpinLock::new(0);


use AtomicI64 ?

some target won't support this width atomic operation, e.g 'https://github.com/rust-lang/rust/blob/dbcb048e2854ab1ce451e98ee52f4b4f3d455335/compiler/rustc_target/src/spec/targets/thumbv7m_none_eabi.rs#L21

AtomicU64 is supported via libatomic on 32-bit platforms. However, it's not lock-free.

Yes, I also think that in most scenarios we should use an efficient implementation, and only fall back to use lock in 32-bit environments.

AtomicU64 is supported via libatomic on 32-bit platforms. However, it's not lock-free.

According to https://doc.rust-lang.org/std/sync/atomic/, rust's Atomic only supports lock-free types, so AtomicU64 might be unavailable on 32-bit platoforms. Using spinlock here LGTM.

zhanghe-vivo · 2026-03-04T08:25:31Z

build_prs #240 vivoblueos/librs#22 vivoblueos/libc#5

github-actions · 2026-03-04T08:26:42Z

Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22661144095.

github-actions · 2026-03-04T08:35:11Z

✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/22661144095.

zhanghe-vivo · 2026-03-05T03:37:13Z

build_prs #240 vivoblueos/librs#22 vivoblueos/libc#5

github-actions · 2026-03-05T03:38:22Z

Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22701076137.

github-actions · 2026-03-05T04:04:16Z

❌ Job failed. Failed jobs: check_format (failure), build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/22701076137.

zhanghe-vivo · 2026-03-05T04:08:17Z

build_prs #240 vivoblueos/librs#22 vivoblueos/libc#5

github-actions · 2026-03-05T04:09:33Z

Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22701822414.

github-actions · 2026-03-05T04:16:55Z

❌ Job failed. Failed jobs: build_and_check_boards (failure), see https://github.com/vivoblueos/kernel/actions/runs/22701822414.

zhanghe-vivo · 2026-03-05T06:02:45Z

build_prs #240 vivoblueos/librs#22 vivoblueos/libc#5

github-actions · 2026-03-05T06:04:02Z

Job is started, see https://github.com/vivoblueos/kernel/actions/runs/22704702662.

github-actions · 2026-03-05T06:13:14Z

✅ All jobs completed successfully, see https://github.com/vivoblueos/kernel/actions/runs/22704702662.

lawkai-vivo changed the title ~~fix semantics of posix time function~~ Fix semantics of posix time function Dec 22, 2025

lawkai-vivo requested review from han-jiang277 and xuchang-vivo December 22, 2025 07:32

zhanghe-vivo force-pushed the zhanghe_posix_time branch from 2cb31b7 to c96c29f Compare December 29, 2025 02:02

zhanghe-vivo force-pushed the zhanghe_posix_time branch from c96c29f to b08053d Compare January 5, 2026 08:57

zhanghe-vivo force-pushed the zhanghe_posix_time branch from b08053d to 70cef89 Compare January 5, 2026 09:17

zhanghe-vivo force-pushed the zhanghe_posix_time branch from 70cef89 to 4599868 Compare January 5, 2026 09:24

zhanghe-vivo force-pushed the zhanghe_posix_time branch from 5b3d30b to 8521569 Compare February 25, 2026 08:25

zhanghe-vivo force-pushed the zhanghe_posix_time branch from 8521569 to 075043b Compare February 25, 2026 08:50

han-jiang277 reviewed Mar 2, 2026

View reviewed changes

lawkai-vivo requested review from lawkai-vivo and removed request for lawkai-vivo March 4, 2026 07:58

lawkai-vivo approved these changes Mar 4, 2026

View reviewed changes

zhanghe-vivo force-pushed the zhanghe_posix_time branch 2 times, most recently from d034ad8 to 915f29f Compare March 4, 2026 08:24

zhanghe-vivo force-pushed the zhanghe_posix_time branch from 915f29f to d260fc8 Compare March 5, 2026 03:36

fix semantics of posix time function

049deda

zhanghe-vivo force-pushed the zhanghe_posix_time branch from d260fc8 to 049deda Compare March 5, 2026 04:07

Conversation

zhanghe-vivo commented Dec 22, 2025

Uh oh!

lawkai-vivo commented Dec 22, 2025

Uh oh!

zhanghe-vivo commented Dec 29, 2025

Uh oh!

zhanghe-vivo commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

zhanghe-vivo commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

zhanghe-vivo commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

zhanghe-vivo commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

zhanghe-vivo commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

zhanghe-vivo commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

zhanghe-vivo commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Jan 5, 2026

Uh oh!

github-actions bot commented Feb 25, 2026

Uh oh!

zhanghe-vivo commented Feb 25, 2026

Uh oh!

github-actions bot commented Feb 25, 2026

Uh oh!

github-actions bot commented Feb 25, 2026

Uh oh!

zhanghe-vivo commented Feb 25, 2026

Uh oh!

github-actions bot commented Feb 25, 2026

Uh oh!

github-actions bot commented Feb 25, 2026

Uh oh!

han-jiang277 Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

zhanghe-vivo Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

han-jiang277 Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhanghe-vivo Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

lawkai-vivo Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

han-jiang277 Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

han-jiang277 Mar 2, 2026 •

edited

Loading

han-jiang277 Mar 4, 2026 •

edited

Loading

lawkai-vivo Mar 5, 2026 •

edited

Loading