fix(web): add deposit input validation and timeline calendar controls - #1178
Merged
vjuliaife merged 1 commit intoSep 2, 2026
Merged
Conversation
|
@Dopezapha Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1051
Closes #1050
Closes #1052
Closes #1053
PR Description
I resolved four user interface issues in the web application focused on the deposit wizard flow and the bond activity timeline.
For Issue #1051 (Deposit amount field validation), the amount input in DepositWizard previously allowed users to click Next with an empty field, zero, or non-numeric values. This caused the UI to silently transition to the preview step displaying 0 XLM or NaN XLM. I added input validation to ensure the amount is present, numeric, strictly greater than zero, and at least 0.1 XLM. I added an inline red error message underneath the input when validation fails and disabled the Next button until a valid amount is entered. Near the input field, I also added a clear minimum deposit hint so users know the requirement upfront.
For Issue #1050 (Deposit receipt explorer link), on the DepositWizard receipt step, the transaction hash was rendered as static monospace text without a link to an on-chain explorer. I wrapped the truncated transaction hash in a link pointing to the Stellar testnet explorer on stellar.expert, opening in a new browser tab with rel=noopener noreferrer. This matches the existing explorer link styling used on the dashboard.
For Issue #1052 (Bond timeline empty state), in the BondTimeline component, when an importer had zero recorded events, the component rendered an empty grid without explaining why no events were visible. I added an inline empty-state notice explaining that no bond activity has occurred yet this month, while keeping the calendar grid visible to maintain UI structure.
For Issue #1053 (Bond timeline Today shortcut), I added a Today shortcut button next to the month navigation arrows in BondTimeline so users who page backward or forward through past or future months can jump back to the current month in a single click.
Changes Made
Testing
Command run:
npx tsc --noEmit -p apps/web/tsconfig.jsonResult:
Zero TypeScript errors found in modified files apps/web/components/DepositWizard.tsx and apps/web/components/BondTimeline.tsx.