fix for not detecting changes on json requests#9
Open
campey wants to merge 3 commits into
Open
Conversation
This fix copies stringify(data) into xhr.responseText if xhr.responseText is undefined. When making a cross-domain JSON query, the xhr.responseText comes back as undefined. This meant that comparing this across calls wasn't working to identify changes and smart updater wouldn't update on subsequent calls. Now it Works.
Author
|
According to this stackoverflow answer
|
This fix copies stringify(data) into xhr.responseText if xhr.responseText is undefined. When making a cross-domain JSON query, the xhr.responseText comes back as undefined. This meant that comparing this across calls wasn't working to identify changes and smart updater wouldn't update on subsequent calls. Now it Works. (hopefully not screwing around with whitespace)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix copies stringify(data) into xhr.responseText if
xhr.responseText is undefined.
When making a cross-domain JSON query, the xhr.responseText comes back
as undefined. This meant that comparing this across calls wasn't working
to identify changes and smart updater wouldn't update on subsequent
calls.
Now it Works.
(sorry about the bad diff... windows fail I think)