Skip to content

fix: preserve response hydration checkpoints#50

Merged
leseb merged 1 commit into
mainfrom
codex/fix-adr2-hydration
Jun 10, 2026
Merged

fix: preserve response hydration checkpoints#50
leseb merged 1 commit into
mainfrom
codex/fix-adr2-hydration

Conversation

@franciscojavierarceo

Copy link
Copy Markdown
Collaborator

Summary

  • Materialize ADR-02 response checkpoints by carrying prior history item IDs forward.
  • Hydrate previous responses/conversations even when the new turn uses store=false, while keeping store=false turns unpersisted.
  • Reject requests that provide both conversation_id and previous_response_id, and assert hydrated upstream request bodies in stateful tests.

Test Plan

  • cargo test -p agentic-core
  • cargo clippy -p agentic-core --all-targets -- -D warnings

Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>

@maralbahari maralbahari left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@franciscojavierarceo thank you for catching the these. LGTM

@leseb leseb merged commit 553ea8f into main Jun 10, 2026
3 checks passed
@leseb leseb deleted the codex/fix-adr2-hydration branch June 10, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants