fix(ci): stop stripping auth token before publish#13
Merged
Conversation
The sed + unset lines were removing NODE_AUTH_TOKEN before publishing, leaving the runner with no credentials — causing ENEEDAUTH. NODE_AUTH_TOKEN handles registry auth; --provenance handles attestation. They are independent. Drop the credential-stripping lines from both canary and release jobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Both
canaryandreleasejobs were running:This stripped
NODE_AUTH_TOKENbefore publishing, leaving the runner unauthenticated →ENEEDAUTH.Root cause
NODE_AUTH_TOKENhandles registry authentication.--provenancehandles attestation. They are independent. Removing the token doesn't enable OIDC auth — it just removes credentials.Fix
Drop the credential-stripping lines from both jobs.
NODE_AUTH_TOKEN(set bysetup-nodevia the repo secret) authenticates the publish;--provenanceattaches the attestation as before.