Skip to content

fix(ci): drop RELEASE_PAT — use default GITHUB_TOKEN#20

Merged
bntvllnt merged 1 commit intomainfrom
fix/ci-drop-release-pat
Apr 27, 2026
Merged

fix(ci): drop RELEASE_PAT — use default GITHUB_TOKEN#20
bntvllnt merged 1 commit intomainfrom
fix/ci-drop-release-pat

Conversation

@bntvllnt
Copy link
Copy Markdown
Contributor

Why

The release job's checkout passed token: \${{ secrets.RELEASE_PAT }}, but no such secret exists in this repo. With the input resolving to an empty string, the auth setup wrote AUTHORIZATION: basic (empty value), then git fetch prompted for a username and aborted with terminal prompts disabled. This blocked v0.3.1 release in run 25018407875.

Fix

Drop the explicit token: line. The release job already declares:

```yaml
permissions:
contents: write # for the chore(release) commit + tag push to main
id-token: write # for npm OIDC provenance
```

so the workflow-issued GITHUB_TOKEN is sufficient for the git push, and OIDC continues to handle npm publish (no NPM_TOKEN needed).

Test plan

  • After merge: `gh workflow run Publish -f bump=patch`
  • Verify Publish Release job's checkout step succeeds
  • Verify chore(release) commit + tag push to main succeeds (branch protection: `enforce_admins: true`, required checks `ci (20)` + `ci (22)`)
  • Verify npm `@vllnt/convex-mcp@0.3.1` published at `latest` dist-tag with provenance
  • Verify GitHub release `v0.3.1` created

The release job's checkout was passing `token: ${{ secrets.RELEASE_PAT }}`,
but no such secret exists in this repo. With the input resolving to an empty
string, git auth setup wrote `AUTHORIZATION: basic ` (empty value), then the
fetch step prompted for a username and aborted with `terminal prompts disabled`.

Drop the explicit token. The job already declares `permissions: contents: write`
+ `id-token: write`, so the default `GITHUB_TOKEN` is sufficient for the
chore(release) commit + tag push and OIDC continues to handle npm publish.
@bntvllnt bntvllnt self-assigned this Apr 27, 2026
@bntvllnt bntvllnt merged commit 8fd2361 into main Apr 27, 2026
2 checks passed
@bntvllnt bntvllnt deleted the fix/ci-drop-release-pat branch April 27, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant