Skip to content

fix: unblock storybook integration CI#146

Open
bntvllnt wants to merge 1 commit intofeat/storybookfrom
fix/storybook-integration-ci
Open

fix: unblock storybook integration CI#146
bntvllnt wants to merge 1 commit intofeat/storybookfrom
fix/storybook-integration-ci

Conversation

@bntvllnt
Copy link
Copy Markdown
Collaborator

Summary

  • add missing "use client" directives to hook-using UI components flagged by the client-directives audit
  • move required ConnectorEdge and MultiSelect props into story args so the story verifier accepts them
  • keep story renders aligned with args-driven Storybook usage

Validation

  • pnpm -F @vllnt/ui exec vitest run src/components/client-directives.test.ts
  • pnpm -F @vllnt/ui exec tsx scripts/verify-stories.ts
  • pnpm -F @vllnt/ui build-storybook

Context

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
storybook Ready Ready Preview, Comment Apr 24, 2026 9:21pm
ui.vllnt.ai Ready Ready Preview, Comment Apr 24, 2026 9:21pm

Request Review

@bntvllnt
Copy link
Copy Markdown
Collaborator Author

Jarvis update — PR 146

Current status

  • Reviewed head 14b38b9adbd06e4a3695801244370acd46427ac4 on fix/storybook-integration-ci against feat/storybook.
  • PR is not draft and GitHub checks currently visible on this branch are green.
  • This run did not push code; it revalidated the current branch state.

Blockers

  • None confirmed.

Validation summary

  • pnpm -F @vllnt/ui exec eslint src/components/activity-log/activity-log.tsx src/components/animated-text/animated-text.tsx src/components/connector-edge/connector-edge.stories.tsx src/components/data-list/data-list.tsx src/components/multi-select/multi-select.stories.tsx src/components/spinner/unicode-spinner.tsx src/components/usage-breakdown/usage-breakdown.tsx --max-warnings 0 --no-warn-ignored
  • pnpm -F @vllnt/ui exec vitest run src/components/client-directives.test.ts
  • pnpm -F @vllnt/ui exec tsx scripts/verify-stories.ts (Checked: 162 components)
  • pnpm -F @vllnt/ui build-storybook

Claude review result

  • BLOCKING: none
  • WARN: one minor style nit in story args and a review-only reminder to confirm every added "use client" directive is actually needed. No blocking regression surfaced.

Codex review result

  • Unavailable for this run: OPENAI_API_KEY is unset, so Codex CLI review could not be executed.

Action for bntvllnt

  1. Do the final human review.
  2. If the "use client" additions and story cleanup match intended scope, merge normally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant